Commit 4701a0dd authored by Qing Wang's avatar Qing Wang Committed by Sam Ravnborg
Browse files

video: fbdev: replace snprintf in show functions with sysfs_emit 



coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: default avatarQing Wang <wangqing@vivo.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1634095680-4377-1-git-send-email-wangqing@vivo.com
parent 26bc3371

drivers/video/fbdev/core/fbsysfs.c

+7 −7
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ static ssize_t show_bpp(struct device *device, struct device_attribute *attr, 
			char *buf)

{

	struct fb_info *fb_info = dev_get_drvdata(device);

	return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->var.bits_per_pixel);

	return sysfs_emit(buf, "%d\n", fb_info->var.bits_per_pixel);

}



static ssize_t store_rotate(struct device *device,
@@ -257,7 +257,7 @@ static ssize_t show_rotate(struct device *device, 
{

	struct fb_info *fb_info = dev_get_drvdata(device);



	return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->var.rotate);

	return sysfs_emit(buf, "%d\n", fb_info->var.rotate);

}



static ssize_t store_virtual(struct device *device,
@@ -285,7 +285,7 @@ static ssize_t show_virtual(struct device *device, 
			    struct device_attribute *attr, char *buf)

{

	struct fb_info *fb_info = dev_get_drvdata(device);

	return snprintf(buf, PAGE_SIZE, "%d,%d\n", fb_info->var.xres_virtual,

	return sysfs_emit(buf, "%d,%d\n", fb_info->var.xres_virtual,

			fb_info->var.yres_virtual);

}
@@ -293,7 +293,7 @@ static ssize_t show_stride(struct device *device, 
			   struct device_attribute *attr, char *buf)

{

	struct fb_info *fb_info = dev_get_drvdata(device);

	return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->fix.line_length);

	return sysfs_emit(buf, "%d\n", fb_info->fix.line_length);

}



static ssize_t store_blank(struct device *device,
@@ -381,7 +381,7 @@ static ssize_t show_pan(struct device *device, 
			struct device_attribute *attr, char *buf)

{

	struct fb_info *fb_info = dev_get_drvdata(device);

	return snprintf(buf, PAGE_SIZE, "%d,%d\n", fb_info->var.xoffset,

	return sysfs_emit(buf, "%d,%d\n", fb_info->var.xoffset,

			fb_info->var.yoffset);

}
@@ -390,7 +390,7 @@ static ssize_t show_name(struct device *device, 
{

	struct fb_info *fb_info = dev_get_drvdata(device);



	return snprintf(buf, PAGE_SIZE, "%s\n", fb_info->fix.id);

	return sysfs_emit(buf, "%s\n", fb_info->fix.id);

}



static ssize_t store_fbstate(struct device *device,
@@ -418,7 +418,7 @@ static ssize_t show_fbstate(struct device *device, 
			    struct device_attribute *attr, char *buf)

{

	struct fb_info *fb_info = dev_get_drvdata(device);

	return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->state);

	return sysfs_emit(buf, "%d\n", fb_info->state);

}



#if IS_ENABLED(CONFIG_FB_BACKLIGHT)