Unverified Commit 483e6ea1 authored by Aidan MacDonald's avatar Aidan MacDonald Committed by Mark Brown
Browse files

regmap-irq: Remove unused type_invert flag 



type_invert is deprecated and no longer used; it can now be removed.

Signed-off-by: default avatarAidan MacDonald <aidanmacdonald.0x0@gmail.com>
Link: https://lore.kernel.org/r/20230216223200.150679-1-aidanmacdonald.0x0@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 74641458

drivers/base/regmap/regmap-irq.c

+2 −9
Original line number Diff line number Diff line
@@ -189,10 +189,6 @@ static void regmap_irq_sync_unlock(struct irq_data *data) 
			if (!d->type_buf_def[i])

				continue;

			reg = d->get_irq_reg(d, d->chip->type_base, i);

			if (d->chip->type_invert)

				ret = regmap_update_bits(d->map, reg,

					d->type_buf_def[i], ~d->type_buf[i]);

			else

			ret = regmap_update_bits(d->map, reg,

						 d->type_buf_def[i], d->type_buf[i]);

			if (ret != 0)
@@ -1028,9 +1024,6 @@ int regmap_add_irq_chip_fwnode(struct fwnode_handle *fwnode, 


			ret = regmap_read(map, reg, &d->type_buf_def[i]);



			if (d->chip->type_invert)

				d->type_buf_def[i] = ~d->type_buf_def[i];



			if (ret) {

				dev_err(map->dev, "Failed to get type defaults at 0x%x: %d\n",

					reg, ret);

include/linux/regmap.h

+0 −3
Original line number Diff line number Diff line
@@ -1555,8 +1555,6 @@ struct regmap_irq_chip_data; 
 * @ack_invert:  Inverted ack register: cleared bits for ack.

 * @clear_ack:  Use this to set 1 and 0 or vice-versa to clear interrupts.

 * @wake_invert: Inverted wake register: cleared bits are wake enabled.

 * @type_invert: Invert the type flags. Deprecated, use config registers

 *		 instead.

 * @type_in_mask: Use the mask registers for controlling irq type. Use this if

 *		  the hardware provides separate bits for rising/falling edge

 *		  or low/high level interrupts and they should be combined into
@@ -1633,7 +1631,6 @@ struct regmap_irq_chip { 
	unsigned int clear_ack:1;

	unsigned int wake_invert:1;

	unsigned int runtime_pm:1;

	unsigned int type_invert:1;

	unsigned int type_in_mask:1;

	unsigned int clear_on_unmask:1;

	unsigned int not_fixed_stride:1;