Commit 48b2e71c authored by Kumar Kartikeya Dwivedi's avatar Kumar Kartikeya Dwivedi Committed by Alexei Starovoitov
Browse files

samples: bpf: Fix uninitialized variable in xdp_redirect_cpu 



While at it, also improve help output when CPU number is greater than
possible.

Fixes: e531a220 ("samples: bpf: Convert xdp_redirect_cpu to XDP samples helper")
Signed-off-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210826120910.454081-1-memxor@gmail.com
parent 3599bc51

samples/bpf/xdp_redirect_cpu_user.c

+3 −2
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static int create_cpu_entry(__u32 cpu, struct bpf_cpumap_val *value, 
static int mark_cpus_unavailable(void)

{

	int ret, i, n_cpus = libbpf_num_possible_cpus();

	__u32 invalid_cpu;

	__u32 invalid_cpu = n_cpus;



	for (i = 0; i < n_cpus; i++) {

		ret = bpf_map_update_elem(avail_fd, &i,
@@ -451,6 +451,7 @@ int main(int argc, char **argv) 
				fprintf(stderr,

				"--cpu nr too large for cpumap err (%d):%s\n",

					errno, strerror(errno));

				usage(argv, long_options, __doc__, mask, true, skel->obj);

				goto end_cpu;

			}

			cpu[added_cpus++] = add_cpu;