Commit 49f79ac2 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Jakub Kicinski
Browse files

net/fungible: Drop redundant pci_enable_pcie_error_reporting() 



pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarDimitris Michailidis <dmichail@fungible.com>
Acked-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ca7f175f

drivers/net/ethernet/fungible/funcore/fun_dev.c

+0 −5
Original line number Diff line number Diff line 
// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)



#include <linux/aer.h>

#include <linux/bitmap.h>

#include <linux/delay.h>

#include <linux/interrupt.h>
@@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev) 
	pci_free_irq_vectors(pdev);



	pci_clear_master(pdev);

	pci_disable_pcie_error_reporting(pdev);

	pci_disable_device(pdev);



	fun_unmap_bars(fdev);
@@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, 
		goto unmap;

	}



	pci_enable_pcie_error_reporting(pdev);



	rc = sanitize_dev(fdev);

	if (rc)

		goto disable_dev;
@@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev, 
free_irqs:

	pci_free_irq_vectors(pdev);

disable_dev:

	pci_disable_pcie_error_reporting(pdev);

	pci_disable_device(pdev);

unmap:

	fun_unmap_bars(fdev);