Commit 4aca56f8 authored by Damien Le Moal's avatar Damien Le Moal Committed by Bjorn Helgaas
Browse files

PCI: epf-test: Fix DMA transfer completion initialization 

Reinitialize the transfer_complete DMA transfer completion before calling
tx_submit(), to avoid seeing the DMA transfer complete before the
completion is initialized, thus potentially losing the completion
notification.

Link: https://lore.kernel.org/r/20230415023542.77601-4-dlemoal@kernel.org


Fixes: 8353813c ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Cc: stable@vger.kernel.org
parent f6ec3397

drivers/pci/endpoint/functions/pci-epf-test.c

+1 −1
Original line number Diff line number Diff line
@@ -151,10 +151,10 @@ static int pci_epf_test_data_transfer(struct pci_epf_test *epf_test, 
		return -EIO;

	}



	reinit_completion(&epf_test->transfer_complete);

	tx->callback = pci_epf_test_dma_callback;

	tx->callback_param = epf_test;

	cookie = tx->tx_submit(tx);

	reinit_completion(&epf_test->transfer_complete);



	ret = dma_submit_error(cookie);

	if (ret) {