Commit 4c00ac50 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Neil Armstrong
Browse files

drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd() 



Now as all drivers stopped calling drm_bridge_connector_enable_hpd() and
drm_bridge_connector_disable_hpd() it is safe to remove them complelely.
Rename our internal helpers to remove the underscore prefix.

Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20221102180705.459294-8-dmitry.baryshkov@linaro.org
parent c4f5538f

drivers/gpu/drm/drm_bridge_connector.c

+4 −29
Original line number Diff line number Diff line
@@ -128,19 +128,7 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, 
	drm_kms_helper_hotplug_event(dev);

}



/**

 * drm_bridge_connector_enable_hpd - Enable hot-plug detection for the connector

 * @connector: The DRM bridge connector

 *

 * This function enables hot-plug detection for the given bridge connector.

 * This is typically used by display drivers in their resume handler.

 */

void drm_bridge_connector_enable_hpd(struct drm_connector *connector)

{

}

EXPORT_SYMBOL_GPL(drm_bridge_connector_enable_hpd);



static void _drm_bridge_connector_enable_hpd(struct drm_connector *connector)

static void drm_bridge_connector_enable_hpd(struct drm_connector *connector)

{

	struct drm_bridge_connector *bridge_connector =

		to_drm_bridge_connector(connector);
@@ -151,20 +139,7 @@ static void _drm_bridge_connector_enable_hpd(struct drm_connector *connector) 
				      bridge_connector);

}



/**

 * drm_bridge_connector_disable_hpd - Disable hot-plug detection for the

 * connector

 * @connector: The DRM bridge connector

 *

 * This function disables hot-plug detection for the given bridge connector.

 * This is typically used by display drivers in their suspend handler.

 */

void drm_bridge_connector_disable_hpd(struct drm_connector *connector)

{

}

EXPORT_SYMBOL_GPL(drm_bridge_connector_disable_hpd);



static void _drm_bridge_connector_disable_hpd(struct drm_connector *connector)

static void drm_bridge_connector_disable_hpd(struct drm_connector *connector)

{

	struct drm_bridge_connector *bridge_connector =

		to_drm_bridge_connector(connector);
@@ -313,8 +288,8 @@ static int drm_bridge_connector_get_modes(struct drm_connector *connector) 
static const struct drm_connector_helper_funcs drm_bridge_connector_helper_funcs = {

	.get_modes = drm_bridge_connector_get_modes,

	/* No need for .mode_valid(), the bridges are checked by the core. */

	.enable_hpd = _drm_bridge_connector_enable_hpd,

	.disable_hpd = _drm_bridge_connector_disable_hpd,

	.enable_hpd = drm_bridge_connector_enable_hpd,

	.disable_hpd = drm_bridge_connector_disable_hpd,

};



/* -----------------------------------------------------------------------------

include/drm/drm_bridge_connector.h

+0 −2
Original line number Diff line number Diff line
@@ -10,8 +10,6 @@ struct drm_connector; 
struct drm_device;

struct drm_encoder;



void drm_bridge_connector_enable_hpd(struct drm_connector *connector);

void drm_bridge_connector_disable_hpd(struct drm_connector *connector);

struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,

						struct drm_encoder *encoder);