Commit 4c1294da authored by Johan Hovold's avatar Johan Hovold Committed by Abhinav Kumar
Browse files

drm/msm/hdmi: fix memory corruption with too many bridges 



Add the missing sanity check on the bridge counter to avoid corrupting
data beyond the fixed-sized bridge array in case there are ever more
than eight bridges.

Fixes: a3376e3e ("drm/msm: convert to drm_bridge")
Cc: stable@vger.kernel.org	# 3.12
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Tested-by: default avatarKuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: default avatarKuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/502670/
Link: https://lore.kernel.org/r/20220913085320.8577-5-johan+linaro@kernel.org


Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent 2e786eb2

drivers/gpu/drm/msm/hdmi/hdmi.c

+5 −0
Original line number Diff line number Diff line
@@ -300,6 +300,11 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi, 
	struct platform_device *pdev = hdmi->pdev;

	int ret;



	if (priv->num_bridges == ARRAY_SIZE(priv->bridges)) {

		DRM_DEV_ERROR(dev->dev, "too many bridges\n");

		return -ENOSPC;

	}



	hdmi->dev = dev;

	hdmi->encoder = encoder;