Unverified Commit 4c2d4e44 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-mlink: special-case HDaudio regular links 



For backwards compatibility, HDaudio/iDISP links are powered-on when
exiting reset, and the existing driver forces them to be powered-off
when entering S0ix. In addition, the get/put helpers are invoked
directly by the ASoC codec drivers, which a historical layering
violation.

Extended links are powered-on by software only, during the probe and
DAI startup phases. This calls for a different handling of the
'regular' and 'extended' audio links.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20230404104127.5629-8-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 17c9b6ec

sound/soc/sof/intel/hda-mlink.c

+22 −4
Original line number Diff line number Diff line
@@ -255,9 +255,13 @@ void hda_bus_ml_put_all(struct hdac_bus *bus) 
{

	struct hdac_ext_link *hlink;



	list_for_each_entry(hlink, &bus->hlink_list, list)

	list_for_each_entry(hlink, &bus->hlink_list, list) {

		struct hdac_ext2_link *h2link = hdac_ext_link_to_ext2(hlink);



		if (!h2link->alt)

			snd_hdac_ext_bus_link_put(bus, hlink);

	}

}

EXPORT_SYMBOL_NS(hda_bus_ml_put_all, SND_SOC_SOF_HDA_MLINK);



void hda_bus_ml_reset_losidv(struct hdac_bus *bus)
@@ -277,7 +281,9 @@ int hda_bus_ml_resume(struct hdac_bus *bus) 


	/* power up links that were active before suspend */

	list_for_each_entry(hlink, &bus->hlink_list, list) {

		if (hlink->ref_count) {

		struct hdac_ext2_link *h2link = hdac_ext_link_to_ext2(hlink);



		if (!h2link->alt && hlink->ref_count) {

			ret = snd_hdac_ext_bus_link_power_up(hlink);

			if (ret < 0)

				return ret;
@@ -289,7 +295,19 @@ EXPORT_SYMBOL_NS(hda_bus_ml_resume, SND_SOC_SOF_HDA_MLINK); 


int hda_bus_ml_suspend(struct hdac_bus *bus)

{

	return snd_hdac_ext_bus_link_power_down_all(bus);

	struct hdac_ext_link *hlink;

	int ret;



	list_for_each_entry(hlink, &bus->hlink_list, list) {

		struct hdac_ext2_link *h2link = hdac_ext_link_to_ext2(hlink);



		if (!h2link->alt) {

			ret = snd_hdac_ext_bus_link_power_down(hlink);

			if (ret < 0)

				return ret;

		}

	}

	return 0;

}

EXPORT_SYMBOL_NS(hda_bus_ml_suspend, SND_SOC_SOF_HDA_MLINK);