Commit 4d3701f9 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: qcom-qmp-pcie-msm8996: clean up power-down handling 



This driver uses v2 registers only so drop the unnecessary
POWER_DOWN_CONTROL override.

Note that this register is already hard-coded when powering on the PHY.

Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221017065013.19647-7-johan+linaro@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5b68d95c

drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c

+2 −8
Original line number Diff line number Diff line
@@ -91,7 +91,6 @@ enum qphy_reg_layout { 
	QPHY_SW_RESET,

	QPHY_START_CTRL,

	QPHY_PCS_STATUS,

	QPHY_PCS_POWER_DOWN_CONTROL,

	/* Keep last to ensure regs_layout arrays are properly initialized */

	QPHY_LAYOUT_SIZE

};
@@ -591,13 +590,8 @@ static int qmp_pcie_msm8996_power_off(struct phy *phy) 
	qphy_clrbits(qphy->pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl);



	/* Put PHY into POWER DOWN state: active low */

	if (cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL]) {

		qphy_clrbits(qphy->pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],

			     cfg->pwrdn_ctrl);

	} else {

	qphy_clrbits(qphy->pcs, QPHY_V2_PCS_POWER_DOWN_CONTROL,

			cfg->pwrdn_ctrl);

	}



	return 0;

}