Commit 4e89780a authored by Deepak R Varma's avatar Deepak R Varma Committed by Borislav Petkov (AMD)
Browse files

EDAC/altera: Remove redundant error logging 



A call to platform_get_irq() already prints an error on failure within
its own implementation. So printing another error based on its return
value in the caller is redundant and should be removed. The clean up
also makes if condition block braces unnecessary. Remove that as well.

Issue identified using platform_get_irq.cocci coccinelle semantic patch.

Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/Y/+j27kqdhflPtaj@ubun2204.myguest.virtualbox.org
parent e8d018dd

drivers/edac/altera_edac.c

+3 −6
Original line number Diff line number Diff line
@@ -2149,10 +2149,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev) 
	}



	edac->sb_irq = platform_get_irq(pdev, 0);

	if (edac->sb_irq < 0) {

		dev_err(&pdev->dev, "No SBERR IRQ resource\n");

	if (edac->sb_irq < 0)

		return edac->sb_irq;

	}



	irq_set_chained_handler_and_data(edac->sb_irq,

					 altr_edac_a10_irq_handler,
@@ -2184,10 +2182,9 @@ static int altr_edac_a10_probe(struct platform_device *pdev) 
	}

#else

	edac->db_irq = platform_get_irq(pdev, 1);

	if (edac->db_irq < 0) {

		dev_err(&pdev->dev, "No DBERR IRQ resource\n");

	if (edac->db_irq < 0)

		return edac->db_irq;

	}



	irq_set_chained_handler_and_data(edac->db_irq,

					 altr_edac_a10_irq_handler, edac);

#endif