Commit 503ebad4 authored Jul 07, 2020 by Hans Verkuil Committed by Mauro Carvalho Chehab Jul 19, 2020

sun4i-csi: call _vb2_fop_release instead of v4l2_fh_release



This driver didn't call _vb2_fop_release in the sun4i_csi_release
function. Without that call the vb2 queue is not properly canceled and
buffers may not be freed.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 71ecc535

drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -242,7 +242,8 @@ static int sun4i_csi_release(struct file *file)

	mutex_lock(&csi->lock);		mutex_lock(&csi->lock);

	v4l2_fh_release(file);		_vb2_fop_release(file, NULL);

	v4l2_pipeline_pm_put(&csi->vdev.entity);		v4l2_pipeline_pm_put(&csi->vdev.entity);
	pm_runtime_put(csi->dev);		pm_runtime_put(csi->dev);