Commit 50445ea2 authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: selftests: Drop redundant vcpu_set_cpuid() from PMU selftest 



Drop a redundant vcpu_set_cpuid() from the PMU test.  The vCPU's CPUID is
set to KVM's supported CPUID by vm_create_with_one_vcpu(), which was also
true back when the helper was named vm_create_default().

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20220614200707.3315957-9-seanjc@google.com
parent ea129d22

tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c

+0 −3
Original line number Diff line number Diff line
@@ -53,7 +53,6 @@ static void guest_code(void) 


int main(int argc, char *argv[])

{

	struct kvm_cpuid2 *cpuid;

	struct kvm_cpuid_entry2 *entry_a_0;

	struct kvm_vm *vm;

	struct kvm_vcpu *vcpu;
@@ -66,7 +65,6 @@ int main(int argc, char *argv[]) 


	/* Create VM */

	vm = vm_create_with_one_vcpu(&vcpu, guest_code);

	cpuid = kvm_get_supported_cpuid();



	TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_PDCM));
@@ -77,7 +75,6 @@ int main(int argc, char *argv[]) 
	__TEST_REQUIRE(eax.split.version_id, "PMU is not supported by the vCPU");



	/* testcase 1, set capabilities when we have PDCM bit */

	vcpu_set_cpuid(vcpu, cpuid);

	vcpu_set_msr(vcpu, MSR_IA32_PERF_CAPABILITIES, PMU_CAP_FW_WRITES);



	/* check capabilities can be retrieved with KVM_GET_MSR */