Commit 5174e5b0 authored by Xiu Jianfeng's avatar Xiu Jianfeng Committed by Stephen Boyd
Browse files

clk: samsung: Fix memory leak in _samsung_clk_register_pll() 



If clk_register() fails, @pll->rate_table may have allocated memory by
kmemdup(), so it needs to be freed, otherwise will cause memory leak
issue, this patch fixes it.

Fixes: 3ff6e0d8 ("clk: samsung: Add support to register rate_table for samsung plls")
Signed-off-by: default avatarXiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221123032015.63980-1-xiujianfeng@huawei.com


Reviewed-by: default avatarAlim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent b55226f8

drivers/clk/samsung/clk-pll.c

+1 −0
Original line number Diff line number Diff line
@@ -1583,6 +1583,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx, 
	if (ret) {

		pr_err("%s: failed to register pll clock %s : %d\n",

			__func__, pll_clk->name, ret);

		kfree(pll->rate_table);

		kfree(pll);

		return;

	}