Commit 51f96e28 authored Jan 10, 2022 by Pali Rohár Committed by Lorenzo Pieralisi Feb 08, 2022

PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ

It is possible that we receive spurious INTx interrupt. Check for the
return value of generic_handle_domain_irq() when processing INTx IRQ.

Link: https://lore.kernel.org/r/20220110015018.26359-6-kabel@kernel.org


Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

parent 1571d67d

drivers/pci/controller/pci-aardvark.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1425,7 +1425,9 @@ static void advk_pcie_handle_int(struct advk_pcie *pcie)
	advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i),		advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i),
	PCIE_ISR1_REG);		PCIE_ISR1_REG);

	generic_handle_domain_irq(pcie->irq_domain, i);		if (generic_handle_domain_irq(pcie->irq_domain, i) == -EINVAL)
			dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n",
			(char)i + 'A');
	}		}
	}		}