Commit 522af60c authored by Dan Carpenter's avatar Dan Carpenter Committed by Christoph Hellwig
Browse files

nvme-tcp: fix error codes in nvme_tcp_setup_ctrl() 



These error paths currently return success but they should return
-EOPNOTSUPP.

Fixes: 73ffcefc ("nvme-tcp: check sgl supported by target")
Fixes: 3f2304f8 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent e7d4b549

drivers/nvme/host/tcp.c

+2 −0
Original line number Diff line number Diff line
@@ -1988,11 +1988,13 @@ static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new) 
		return ret;



	if (ctrl->icdoff) {

		ret = -EOPNOTSUPP;

		dev_err(ctrl->device, "icdoff is not supported!\n");

		goto destroy_admin;

	}



	if (!(ctrl->sgls & ((1 << 0) | (1 << 1)))) {

		ret = -EOPNOTSUPP;

		dev_err(ctrl->device, "Mandatory sgls are not supported!\n");

		goto destroy_admin;

	}