Commit 549e622b authored by Daniel Scally's avatar Daniel Scally Committed by Mauro Carvalho Chehab
Browse files

media: entity: Use dedicated data link iterator 



Where iteration over links for an entity is clearly assuming that
all of those links are data links, use the new iterator to guarantee
that assumption is met.

Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarDaniel Scally <djrscally@gmail.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 1ed3d644

drivers/media/mc/mc-entity.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -450,7 +450,7 @@ __must_check int __media_pipeline_start(struct media_entity *entity, 
		bitmap_zero(active, entity->num_pads);

		bitmap_zero(active, entity->num_pads);

		bitmap_fill(has_no_links, entity->num_pads);

		bitmap_fill(has_no_links, entity->num_pads);





		list_for_each_entry(link, &entity->links, list) {

		for_each_media_entity_data_link(entity, link) {

			struct media_pad *pad = link->sink->entity == entity

			struct media_pad *pad = link->sink->entity == entity

						? link->sink : link->source;

						? link->sink : link->source;
@@ -889,7 +889,7 @@ media_entity_find_link(struct media_pad *source, struct media_pad *sink) 
{

{

	struct media_link *link;

	struct media_link *link;





	list_for_each_entry(link, &source->entity->links, list) {

	for_each_media_entity_data_link(source->entity, link) {

		if (link->source->entity == source->entity &&

		if (link->source->entity == source->entity &&

		    link->source->index == source->index &&

		    link->source->index == source->index &&

		    link->sink->entity == sink->entity &&

		    link->sink->entity == sink->entity &&
@@ -905,7 +905,7 @@ struct media_pad *media_entity_remote_pad(const struct media_pad *pad) 
{

{

	struct media_link *link;

	struct media_link *link;





	list_for_each_entry(link, &pad->entity->links, list) {

	for_each_media_entity_data_link(pad->entity, link) {

		if (!(link->flags & MEDIA_LNK_FL_ENABLED))

		if (!(link->flags & MEDIA_LNK_FL_ENABLED))

			continue;

			continue;