Commit 54f30b83 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Michael Ellerman
Browse files

powerpc: address missing-prototypes warnings 



There are a few warnings in powerpc64 defconfig builds after -Wmissing-prototypes
gets promoted from W=1 to the default warning set:

arch/powerpc/mm/book3s64/pgtable.c:422:6: error: no previous prototype for 'arch_report_meminfo' [-Werror=missing-prototypes]
arch/powerpc/platforms/cell/ras.c:275:5: error: no previous prototype for 'cbe_sysreset_hack' [-Werror=missing-prototypes]
arch/powerpc/platforms/cell/spu_manage.c:29:21: error: no previous prototype for 'spu_devnode' [-Werror=missing-prototypes]
arch/powerpc/platforms/pasemi/time.c:12:17: error: no previous prototype for 'pas_get_boot_time' [-Werror=missing-prototypes]
arch/powerpc/platforms/powermac/feature.c:1532:13: error: no previous prototype for 'g5_phy_disable_cpu1' [-Werror=missing-prototypes]
arch/powerpc/platforms/86xx/pic.c:28:13: error: no previous prototype for 'mpc86xx_init_irq' [-Werror=missing-prototypes]
drivers/pci/pci-sysfs.c:936:13: error: no previous prototype for 'pci_adjust_legacy_attr' [-Werror=missing-prototypes]

Address these by including the right header files or marking the
functions static. The audit.c one is a bit tricky since compat_audit.h
cannot include regular kernel headers tht have conflicting types on
32-bit powerpc.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
[mpe: Drop change to __vmemmap_free() which only exists in mm]
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230727122720.2558065-1-arnd@kernel.org
parent c3062ede

arch/powerpc/include/asm/pci.h

+2 −1
Original line number Diff line number Diff line
@@ -82,7 +82,8 @@ extern int pci_legacy_write(struct pci_bus *bus, loff_t port, u32 val, 
extern int pci_mmap_legacy_page_range(struct pci_bus *bus,

				      struct vm_area_struct *vma,

				      enum pci_mmap_state mmap_state);



extern void pci_adjust_legacy_attr(struct pci_bus *bus,

				   enum pci_mmap_state mmap_type);

#define HAVE_PCI_LEGACY	1



extern void pcibios_claim_one_bus(struct pci_bus *b);

arch/powerpc/kernel/audit.c

+2 −1
Original line number Diff line number Diff line
@@ -4,6 +4,8 @@ 
#include <linux/audit.h>

#include <asm/unistd.h>



#include "audit_32.h"



static unsigned dir_class[] = {

#include <asm-generic/audit_dir_write.h>

~0U
@@ -41,7 +43,6 @@ int audit_classify_arch(int arch) 
int audit_classify_syscall(int abi, unsigned syscall)

{

#ifdef CONFIG_PPC64

	extern int ppc32_classify_syscall(unsigned);

	if (abi == AUDIT_ARCH_PPC)

		return ppc32_classify_syscall(syscall);

#endif

arch/powerpc/kernel/audit_32.h

0 → 100644
+7 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

#ifndef __AUDIT_32_H__

#define __AUDIT_32_H__



extern int ppc32_classify_syscall(unsigned);



#endif

arch/powerpc/kernel/compat_audit.c

+2 −0
Original line number Diff line number Diff line
@@ -3,6 +3,8 @@ 
#include <linux/audit_arch.h>

#include <asm/unistd.h>



#include "audit_32.h"



unsigned ppc32_dir_class[] = {

#include <asm-generic/audit_dir_write.h>

~0U

arch/powerpc/mm/book3s64/pgtable.c

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#include <linux/memremap.h>

#include <linux/pkeys.h>

#include <linux/debugfs.h>

#include <linux/proc_fs.h>

#include <misc/cxl-base.h>



#include <asm/pgalloc.h>