Commit 5519fea9 authored by Christian König's avatar Christian König
Browse files

drm: remove drm_dev_set_unique 



Not used by any drivers any more, the only use case in drm_dev_init()
can be inlined now.

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230316082035.567520-2-christian.koenig@amd.com
parent e0dfefa0

drivers/gpu/drm/drm_drv.c

+4 −22
Original line number Diff line number Diff line
@@ -691,9 +691,11 @@ static int drm_dev_init(struct drm_device *dev, 
		}

	}



	ret = drm_dev_set_unique(dev, dev_name(parent));

	if (ret)

	dev->unique = drmm_kstrdup(dev, dev_name(parent), GFP_KERNEL);

	if (!dev->unique) {

		ret = -ENOMEM;

		goto err;

	}



	return 0;
@@ -1000,26 +1002,6 @@ void drm_dev_unregister(struct drm_device *dev) 
}

EXPORT_SYMBOL(drm_dev_unregister);



/**

 * drm_dev_set_unique - Set the unique name of a DRM device

 * @dev: device of which to set the unique name

 * @name: unique name

 *

 * Sets the unique name of a DRM device using the specified string. This is

 * already done by drm_dev_init(), drivers should only override the default

 * unique name for backwards compatibility reasons.

 *

 * Return: 0 on success or a negative error code on failure.

 */

int drm_dev_set_unique(struct drm_device *dev, const char *name)

{

	drmm_kfree(dev, dev->unique);

	dev->unique = drmm_kstrdup(dev, name, GFP_KERNEL);



	return dev->unique ? 0 : -ENOMEM;

}

EXPORT_SYMBOL(drm_dev_set_unique);



/*

 * DRM Core

 * The DRM core module initializes all global DRM objects and makes them

include/drm/drm_drv.h

+0 −2
Original line number Diff line number Diff line
@@ -584,8 +584,6 @@ static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev) 
}





int drm_dev_set_unique(struct drm_device *dev, const char *name);



/* TODO: Inline drm_firmware_drivers_only() in all its callers. */

static inline bool drm_firmware_drivers_only(void)

{