Commit 560458df authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Vinod Koul
Browse files

soundwire: bus: Fix wrong port number in sdw_handle_slave_alerts() 



for_each_set_bit() gives the bit-number counting from 0 (LSbit==0).
When processing INTSTAT2, bit 0 is DP4 so the port number is (bit + 4).
Likewise for INTSTAT3 bit 0 is DP11 so port number is (bit + 11).

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220917140256.689678-1-rf@opensource.cirrus.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent ed8d07ac

drivers/soundwire/bus.c

+2 −2
Original line number Diff line number Diff line
@@ -1622,7 +1622,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) 
			port = buf2[0] & SDW_SCP_INTSTAT2_PORT4_10;

			for_each_set_bit(bit, &port, 8) {

				/* scp2 ports start from 4 */

				port_num = bit + 3;

				port_num = bit + 4;

				sdw_handle_port_interrupt(slave,

						port_num,

						&port_status[port_num]);
@@ -1634,7 +1634,7 @@ static int sdw_handle_slave_alerts(struct sdw_slave *slave) 
			port = buf2[1] & SDW_SCP_INTSTAT3_PORT11_14;

			for_each_set_bit(bit, &port, 8) {

				/* scp3 ports start from 11 */

				port_num = bit + 10;

				port_num = bit + 11;

				sdw_handle_port_interrupt(slave,

						port_num,

						&port_status[port_num]);