Commit 5621a0bc authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

edd: simplify the check of 'attr->test' in edd_populate_dir() 



attr->test check is not needed when !attr->test is false.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220511064622.3399164-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c337125b

drivers/firmware/edd.c

+1 −2
Original line number Diff line number Diff line
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev) 
	int i;



	for (i = 0; (attr = edd_attrs[i]) && !error; i++) {

		if (!attr->test ||

		    (attr->test && attr->test(edev)))

		if (!attr->test || attr->test(edev))

			error = sysfs_create_file(&edev->kobj,&attr->attr);

	}