Commit 56a9ecd2 authored by Mathieu Poirier's avatar Mathieu Poirier Committed by Greg Kroah-Hartman
Browse files

coresight: Fix W=1 warnings in core framework 



  CC      drivers/hwtracing/coresight/coresight-etm4x-sysfs.o
  CC      drivers/hwtracing/coresight/coresight-stm.o
drivers/hwtracing/coresight/coresight-core.c:440: warning: Function parameter or member 'csdev' not described in 'coresight_disable_source'
drivers/hwtracing/coresight/coresight-core.c:670: warning: Function parameter or member 'csdev' not described in 'coresight_get_ref'
drivers/hwtracing/coresight/coresight-core.c:687: warning: Function parameter or member 'csdev' not described in 'coresight_put_ref'
drivers/hwtracing/coresight/coresight-core.c:758: warning: Function parameter or member 'sink' not described in '_coresight_build_path'
  CC      drivers/hwtracing/coresight/coresight-cpu-debug.o
  CC      drivers/hwtracing/coresight/coresight-catu.o

Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20201127175256.1092685-14-mathieu.poirier@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1cc573d5

drivers/hwtracing/coresight/coresight-core.c

+7 −1
Original line number Diff line number Diff line
@@ -432,7 +432,7 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode) 
 *  coresight_disable_source - Drop the reference count by 1 and disable

 *  the device if there are no users left.

 *

 *  @csdev - The coresight device to disable

 *  @csdev: The coresight device to disable

 *

 *  Returns true if the device has been disabled.

 */
@@ -663,6 +663,9 @@ struct coresight_device *coresight_get_sink_by_id(u32 id) 
/**

 * coresight_get_ref- Helper function to increase reference count to module

 * and device.

 *

 * @csdev: The coresight device to get a reference on.

 *

 * Return true in successful case and power up the device.

 * Return false when failed to get reference of module.

 */
@@ -682,6 +685,8 @@ static inline bool coresight_get_ref(struct coresight_device *csdev) 
/**

 * coresight_put_ref- Helper function to decrease reference count to module

 * and device. Power off the device.

 *

 * @csdev: The coresight device to decrement a reference from.

 */

static inline void coresight_put_ref(struct coresight_device *csdev)

{
@@ -744,6 +749,7 @@ static void coresight_drop_device(struct coresight_device *csdev) 
/**

 * _coresight_build_path - recursively build a path from a @csdev to a sink.

 * @csdev:	The device to start from.

 * @sink:	The final sink we want in this path.

 * @path:	The list to add devices to.

 *

 * The tree of Coresight device is traversed until an activated sink is