Commit 57eddec8 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Lorenzo Pieralisi
Browse files

PCI: qcom: Use bitfield definitions for register fields 

To maintain uniformity throughout the driver and also to make the code
easier to read, let's make use of bitfield definitions for register fields.

Link: https://lore.kernel.org/r/20230316081117.14288-5-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
parent 769e49d8

drivers/pci/controller/dwc/pcie-qcom.c

+7 −7
Original line number Diff line number Diff line
@@ -76,24 +76,24 @@ 
#define REQ_NOT_ENTR_L1				BIT(5)



/* PARF_PCS_DEEMPH register fields */

#define PCS_DEEMPH_TX_DEEMPH_GEN1(x)		((x) << 16)

#define PCS_DEEMPH_TX_DEEMPH_GEN2_3_5DB(x)	((x) << 8)

#define PCS_DEEMPH_TX_DEEMPH_GEN2_6DB(x)	((x) << 0)

#define PCS_DEEMPH_TX_DEEMPH_GEN1(x)		FIELD_PREP(GENMASK(21, 16), x)

#define PCS_DEEMPH_TX_DEEMPH_GEN2_3_5DB(x)	FIELD_PREP(GENMASK(13, 8), x)

#define PCS_DEEMPH_TX_DEEMPH_GEN2_6DB(x)	FIELD_PREP(GENMASK(5, 0), x)



/* PARF_PCS_SWING register fields */

#define PCS_SWING_TX_SWING_FULL(x)		((x) << 8)

#define PCS_SWING_TX_SWING_LOW(x)		((x) << 0)

#define PCS_SWING_TX_SWING_FULL(x)		FIELD_PREP(GENMASK(14, 8), x)

#define PCS_SWING_TX_SWING_LOW(x)		FIELD_PREP(GENMASK(6, 0), x)



/* PARF_PHY_CTRL register fields */

#define PHY_CTRL_PHY_TX0_TERM_OFFSET_MASK	GENMASK(20, 16)

#define PHY_CTRL_PHY_TX0_TERM_OFFSET(x)		((x) << 16)

#define PHY_CTRL_PHY_TX0_TERM_OFFSET(x)		FIELD_PREP(PHY_CTRL_PHY_TX0_TERM_OFFSET_MASK, x)



/* PARF_PHY_REFCLK register fields */

#define PHY_REFCLK_SSP_EN			BIT(16)

#define PHY_REFCLK_USE_PAD			BIT(12)



/* PARF_CONFIG_BITS register fields */

#define PHY_RX0_EQ(x)				((x) << 24)

#define PHY_RX0_EQ(x)				FIELD_PREP(GENMASK(26, 24), x)



/* PARF_SLV_ADDR_SPACE_SIZE register value */

#define SLV_ADDR_SPACE_SZ			0x10000000