Unverified Commit 5801eda9 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/vc4: dpi: Remove unnecessary drm_of_panel_bridge_remove call 



Since we have a managed call to create our panel_bridge instance, the call
to drm_of_panel_bridge_remove() at unbind is both redundant and dangerous
since it might lead to a use-after-free.

Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-28-maxime@cerno.tech
parent ff5b18ce

drivers/gpu/drm/vc4/vc4_dpi.c

+0 −2
Original line number Diff line number Diff line
@@ -329,8 +329,6 @@ static void vc4_dpi_unbind(struct device *dev, struct device *master, 
{

	struct vc4_dpi *dpi = dev_get_drvdata(dev);



	drm_of_panel_bridge_remove(dev->of_node, 0, 0);



	drm_encoder_cleanup(&dpi->encoder.base);



	clk_disable_unprepare(dpi->core_clock);