Commit 58b18011 authored by Tejun Heo's avatar Tejun Heo
Browse files

wifi: mwifiex: Use default @max_active for workqueues 



These workqueues only host a single work item and thus doen't need explicit
concurrency limit. Let's use the default @max_active. This doesn't cost
anything and clearly expresses that @max_active doesn't matter.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Reviewed-by: default avatarBrian Norris <briannorris@chromium.org>
Acked-by: default avatarKalle Valo <kvalo@kernel.org>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: Ganapathi Bhat <ganapathi017@gmail.com>
Cc: Sharvari Harisangam <sharvari.harisangam@nxp.com>
Cc: Xinming Hu <huxinming820@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
parent 4c1b3f26

drivers/net/wireless/marvell/mwifiex/cfg80211.c

+2 −2
Original line number Diff line number Diff line
@@ -3127,7 +3127,7 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy, 
	priv->dfs_cac_workqueue = alloc_workqueue("MWIFIEX_DFS_CAC%s",

						  WQ_HIGHPRI |

						  WQ_MEM_RECLAIM |

						  WQ_UNBOUND, 1, name);

						  WQ_UNBOUND, 0, name);

	if (!priv->dfs_cac_workqueue) {

		mwifiex_dbg(adapter, ERROR, "cannot alloc DFS CAC queue\n");

		ret = -ENOMEM;
@@ -3138,7 +3138,7 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct wiphy *wiphy, 


	priv->dfs_chan_sw_workqueue = alloc_workqueue("MWIFIEX_DFS_CHSW%s",

						      WQ_HIGHPRI | WQ_UNBOUND |

						      WQ_MEM_RECLAIM, 1, name);

						      WQ_MEM_RECLAIM, 0, name);

	if (!priv->dfs_chan_sw_workqueue) {

		mwifiex_dbg(adapter, ERROR, "cannot alloc DFS channel sw queue\n");

		ret = -ENOMEM;

drivers/net/wireless/marvell/mwifiex/main.c

+4 −4
Original line number Diff line number Diff line
@@ -1547,7 +1547,7 @@ mwifiex_reinit_sw(struct mwifiex_adapter *adapter) 


	adapter->workqueue =

		alloc_workqueue("MWIFIEX_WORK_QUEUE",

				WQ_HIGHPRI | WQ_MEM_RECLAIM | WQ_UNBOUND, 1);

				WQ_HIGHPRI | WQ_MEM_RECLAIM | WQ_UNBOUND, 0);

	if (!adapter->workqueue)

		goto err_kmalloc;
@@ -1557,7 +1557,7 @@ mwifiex_reinit_sw(struct mwifiex_adapter *adapter) 
		adapter->rx_workqueue = alloc_workqueue("MWIFIEX_RX_WORK_QUEUE",

							WQ_HIGHPRI |

							WQ_MEM_RECLAIM |

							WQ_UNBOUND, 1);

							WQ_UNBOUND, 0);

		if (!adapter->rx_workqueue)

			goto err_kmalloc;

		INIT_WORK(&adapter->rx_work, mwifiex_rx_work_queue);
@@ -1702,7 +1702,7 @@ mwifiex_add_card(void *card, struct completion *fw_done, 


	adapter->workqueue =

		alloc_workqueue("MWIFIEX_WORK_QUEUE",

				WQ_HIGHPRI | WQ_MEM_RECLAIM | WQ_UNBOUND, 1);

				WQ_HIGHPRI | WQ_MEM_RECLAIM | WQ_UNBOUND, 0);

	if (!adapter->workqueue)

		goto err_kmalloc;
@@ -1712,7 +1712,7 @@ mwifiex_add_card(void *card, struct completion *fw_done, 
		adapter->rx_workqueue = alloc_workqueue("MWIFIEX_RX_WORK_QUEUE",

							WQ_HIGHPRI |

							WQ_MEM_RECLAIM |

							WQ_UNBOUND, 1);

							WQ_UNBOUND, 0);

		if (!adapter->rx_workqueue)

			goto err_kmalloc;