Commit 593d7b89 authored by Liang He's avatar Liang He Committed by Michael Ellerman
Browse files

powerpc/52xx: Add missing of_node_put() in media5200.c 



In media5200_init_irq(), of_find_compatible_node() will return a
node pointer with refcount incremented. The reference should be dropped
with of_node_put() in the failure path or when it is not used anymore.

Don't worry about 'fpga_np == NULL' as of_node_put() can correctly
handle that.

Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220616144007.3987743-1-windhl@126.com
parent 64e696af

arch/powerpc/platforms/52xx/media5200.c

+3 −0
Original line number Diff line number Diff line
@@ -174,6 +174,8 @@ static void __init media5200_init_irq(void) 
		goto out;

	pr_debug("%s: allocated irqhost\n", __func__);



	of_node_put(fpga_np);



	irq_set_handler_data(cascade_virq, &media5200_irq);

	irq_set_chained_handler(cascade_virq, media5200_irq_cascade);
@@ -181,6 +183,7 @@ static void __init media5200_init_irq(void) 


 out:

	pr_err("Could not find Media5200 FPGA; PCI interrupts will not work\n");

	of_node_put(fpga_np);

}



/*