Commit 598dbdf2 authored by Robin Dong's avatar Robin Dong Committed by Theodore Ts'o
Browse files

ext4: avoid unneeded ext4_ext_next_leaf_block() while inserting extents 



Optimize ext4_ext_insert_extent() by avoiding
ext4_ext_next_leaf_block() when the result is not used/needed.

Signed-off-by: default avatarRobin Dong <sanbai@taobao.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent ffb505ff

fs/ext4/extents.c

+4 −3
Original line number Diff line number Diff line
@@ -1730,9 +1730,10 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, 


	/* probably next leaf has space for us? */

	fex = EXT_LAST_EXTENT(eh);

	next = EXT_MAX_BLOCKS;

	if (le32_to_cpu(newext->ee_block) > le32_to_cpu(fex->ee_block))

		next = ext4_ext_next_leaf_block(inode, path);

	if (le32_to_cpu(newext->ee_block) > le32_to_cpu(fex->ee_block)

	    && next != EXT_MAX_BLOCKS) {

	if (next != EXT_MAX_BLOCKS) {

		ext_debug("next leaf block - %d\n", next);

		BUG_ON(npath != NULL);

		npath = ext4_ext_find_extent(inode, next, NULL);