Unverified Commit 59a6cc5c authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: rockchip: simplify error handling 



cppcheck warning:

sound/soc/rockchip/rk3288_hdmi_analog.c:256:9: warning: Identical
condition and return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/rockchip/rk3288_hdmi_analog.c:252:6: note: If condition
'ret' is true, the function will return/exit
 if (ret)
     ^
sound/soc/rockchip/rk3288_hdmi_analog.c:256:9: note: Returning
identical expression 'ret'
 return ret;
        ^

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220520211719.607543-15-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7518be0c

sound/soc/rockchip/rk3288_hdmi_analog.c

+2 −2
Original line number Diff line number Diff line
@@ -169,7 +169,7 @@ static struct snd_soc_card snd_soc_card_rk = { 


static int snd_rk_mc_probe(struct platform_device *pdev)

{

	int ret = 0;

	int ret;

	struct snd_soc_card *card = &snd_soc_card_rk;

	struct device_node *np = pdev->dev.of_node;

	struct rk_drvdata *machine;
@@ -253,7 +253,7 @@ static int snd_rk_mc_probe(struct platform_device *pdev) 
		return dev_err_probe(&pdev->dev, ret,

				     "Soc register card failed\n");



	return ret;

	return 0;

}



static const struct of_device_id rockchip_sound_of_match[] = {