Commit 5ad2e460 authored by Marco Felsch's avatar Marco Felsch Committed by Mauro Carvalho Chehab
Browse files

media: i2c: tc358746: fix possible endianness issue 



Using the u64 v4l2_dbg_register.val directly can lead to unexpected
results depending on machine endianness. Fix this by using a local
variable which is assigned afterwards. Since tc358746_read() will init
the val variable to 0 we can assing it without checking the return value
first.

Addresses-Coverity-ID: 1527256 ("Integer handling issues")

Reported-by: default avatarcoverity-bot <keescook+coverity-bot@chromium.org>
Fixes: 80a21da3 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
Signed-off-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 9d33802c

drivers/media/i2c/tc358746.c

+3 −1
Original line number Diff line number Diff line
@@ -988,6 +988,7 @@ static int __maybe_unused 
tc358746_g_register(struct v4l2_subdev *sd, struct v4l2_dbg_register *reg)

{

	struct tc358746 *tc358746 = to_tc358746(sd);

	u32 val;

	int err;



	/* 32-bit registers starting from CLW_DPHYCONTTX */
@@ -996,7 +997,8 @@ tc358746_g_register(struct v4l2_subdev *sd, struct v4l2_dbg_register *reg) 
	if (!pm_runtime_get_if_in_use(sd->dev))

		return 0;



	err = tc358746_read(tc358746, reg->reg, (u32 *)&reg->val);

	err = tc358746_read(tc358746, reg->reg, &val);

	reg->val = val;



	pm_runtime_mark_last_busy(sd->dev);

	pm_runtime_put_sync_autosuspend(sd->dev);