Unverified Commit 5b45759c authored Aug 03, 2023 by Rob Herring Committed by Arnd Bergmann Aug 12, 2023

firmware: Explicitly include correct DT includes



The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20230803-dt-header-cleanups-for-soc-v2-17-d8de2cc88bff@kernel.org


Signed-off-by: Arnd Bergmann <arnd@arndb.de>

parent 53c5ae63

drivers/firmware/arm_scmi/driver.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -28,8 +28,8 @@
	#include <linux/hashtable.h>		#include <linux/hashtable.h>
	#include <linux/list.h>		#include <linux/list.h>
	#include <linux/module.h>		#include <linux/module.h>
	#include <linux/of_address.h>		#include <linux/of.h>
	#include <linux/of_device.h>		#include <linux/platform_device.h>
	#include <linux/processor.h>		#include <linux/processor.h>
	#include <linux/refcount.h>		#include <linux/refcount.h>
	#include <linux/slab.h>		#include <linux/slab.h>

drivers/firmware/imx/imx-dsp.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -10,7 +10,6 @@
	#include <linux/kernel.h>		#include <linux/kernel.h>
	#include <linux/mailbox_client.h>		#include <linux/mailbox_client.h>
	#include <linux/module.h>		#include <linux/module.h>
	#include <linux/of_platform.h>
	#include <linux/platform_device.h>		#include <linux/platform_device.h>
	#include <linux/slab.h>		#include <linux/slab.h>

drivers/firmware/imx/imx-scu-irq.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -10,6 +10,7 @@
	#include <linux/firmware/imx/ipc.h>		#include <linux/firmware/imx/ipc.h>
	#include <linux/firmware/imx/sci.h>		#include <linux/firmware/imx/sci.h>
	#include <linux/mailbox_client.h>		#include <linux/mailbox_client.h>
			#include <linux/of.h>
	#include <linux/suspend.h>		#include <linux/suspend.h>

	#define IMX_SC_IRQ_FUNC_ENABLE 1		#define IMX_SC_IRQ_FUNC_ENABLE 1

drivers/firmware/imx/imx-scu.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -16,6 +16,7 @@
	#include <linux/mailbox_client.h>		#include <linux/mailbox_client.h>
	#include <linux/module.h>		#include <linux/module.h>
	#include <linux/mutex.h>		#include <linux/mutex.h>
			#include <linux/of.h>
	#include <linux/of_platform.h>		#include <linux/of_platform.h>
	#include <linux/platform_device.h>		#include <linux/platform_device.h>

drivers/firmware/mtk-adsp-ipc.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -8,7 +8,6 @@
	#include <linux/kernel.h>		#include <linux/kernel.h>
	#include <linux/mailbox_client.h>		#include <linux/mailbox_client.h>
	#include <linux/module.h>		#include <linux/module.h>
	#include <linux/of_platform.h>
	#include <linux/platform_device.h>		#include <linux/platform_device.h>
	#include <linux/slab.h>		#include <linux/slab.h>