Commit 5c0480de authored by Wan Jiabing's avatar Wan Jiabing Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: Use memdup_user instead of kmalloc/copy_from_user 



Fix following coccicheck warning:
./drivers/staging/r8188eu/os_dep/ioctl_linux.c:1986:8-15: WARNING
opportunity for memdup_user.

Use memdup_user rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: default avatarWan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211021122015.6974-1-wanjiabing@vivo.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9da4b50c

drivers/staging/r8188eu/os_dep/ioctl_linux.c

+3 −8
Original line number Diff line number Diff line
@@ -1984,14 +1984,9 @@ static int rtw_wx_read32(struct net_device *dev, 
	padapter = (struct adapter *)rtw_netdev_priv(dev);

	p = &wrqu->data;

	len = p->length;

	ptmp = kmalloc(len, GFP_KERNEL);

	if (!ptmp)

		return -ENOMEM;



	if (copy_from_user(ptmp, p->pointer, len)) {

		kfree(ptmp);

		return -EFAULT;

	}

	ptmp = memdup_user(p->pointer, len);

	if (IS_ERR(ptmp))

		return PTR_ERR(ptmp);



	bytes = 0;

	addr = 0;