Commit 60e388e8 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix invalid verbs for mic-boosts on AD1884* 



The mic-boosts (0x14 and 0x15) on AD1884* codecs are input-amps,
not output-amps.  Fix the invalid initialization verbs.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 19a2d3e9

sound/pci/hda/patch_analog.c

+4 −4
Original line number Diff line number Diff line
@@ -3183,10 +3183,10 @@ static struct hda_verb ad1884_init_verbs[] = { 
	{0x0e, AC_VERB_SET_CONNECT_SEL, 0x1},

	/* Port-B (front mic) pin */

	{0x14, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80},

	{0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},

	{0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},

	/* Port-C (rear mic) pin */

	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80},

	{0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},

	{0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},

	/* Analog mixer; mute as default */

	{0x20, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(0)},

	{0x20, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(1)},
@@ -3601,10 +3601,10 @@ static struct hda_verb ad1884a_init_verbs[] = { 
	{0x13, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},

	/* Port-B (front mic) pin */

	{0x14, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80},

	{0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},

	{0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},

	/* Port-C (rear line-in) pin */

	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},

	{0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},

	{0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},

	/* Port-E (rear mic) pin */

	{0x1c, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80},

	{0x1c, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},