Commit 61795a53 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: lpfc: Remove dead code on second !ndlp check 

Currently there is a null check on the pointer ndlp that exits via error
path issue_ct_rsp_exit followed by another null check on the same pointer
that is almost identical to the previous null check stanza and yet can
never can be reached because the previous check exited via
issue_ct_rsp_exit. This is deadcode and can be removed.

Link: https://lore.kernel.org/r/20201118133744.461385-1-colin.king@canonical.com


Reviewed-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Logically dead code")
parent 1e7dddb2

drivers/scsi/lpfc/lpfc_bsg.c

+0 −6
Original line number Diff line number Diff line
@@ -1526,12 +1526,6 @@ lpfc_issue_ct_rsp(struct lpfc_hba *phba, struct bsg_job *job, uint32_t tag, 
			goto issue_ct_rsp_exit;

		}



		/* Check if the ndlp is active */

		if (!ndlp) {

			rc = IOCB_ERROR;

			goto issue_ct_rsp_exit;

		}



		/* get a refernece count so the ndlp doesn't go away while

		 * we respond

		 */