Commit 62cd69a1 authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by David S. Miller
Browse files

jazzsonic: free irq if sonic_open() fails 



jazzsonic_open() doesn't check sonic_open() return code. If it is error
we must free requested IRQ.

Signed-off-by: default avatarKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84ce981a

drivers/net/jazzsonic.c

+13 −4
Original line number Diff line number Diff line
@@ -82,11 +82,20 @@ static unsigned short known_revisions[] = 


static int jazzsonic_open(struct net_device* dev)

{

	if (request_irq(dev->irq, sonic_interrupt, IRQF_DISABLED, "sonic", dev)) {

		printk(KERN_ERR "%s: unable to get IRQ %d.\n", dev->name, dev->irq);

		return -EAGAIN;

	int retval;



	retval = request_irq(dev->irq, sonic_interrupt, IRQF_DISABLED,

				"sonic", dev);

	if (retval) {

		printk(KERN_ERR "%s: unable to get IRQ %d.\n",

				dev->name, dev->irq);

		return retval;

	}

	return sonic_open(dev);



	retval = sonic_open(dev);

	if (retval)

		free_irq(dev->irq, dev);

	return retval;

}



static int jazzsonic_close(struct net_device* dev)