Commit 6304da8a authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Remove FBINFO_DEFAULT from static structs 



The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by a static declaration. So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-3-tzimmermann@suse.de
parent 40e324e0

drivers/video/fbdev/68328fb.c

+1 −1
Original line number Diff line number Diff line
@@ -448,7 +448,7 @@ static int __init mc68x328fb_init(void) 
		fb_info.var.red.offset = fb_info.var.green.offset = fb_info.var.blue.offset = 0;

	}

	fb_info.pseudo_palette = &mc68x328fb_pseudo_palette;

	fb_info.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

	fb_info.flags = FBINFO_HWACCEL_YPAN;



	if (fb_alloc_cmap(&fb_info.cmap, 256, 0))

		return -ENOMEM;

drivers/video/fbdev/acornfb.c

+1 −1
Original line number Diff line number Diff line
@@ -694,7 +694,7 @@ static void acornfb_init_fbinfo(void) 
	first = 0;



	fb_info.fbops		= &acornfb_ops;

	fb_info.flags		= FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

	fb_info.flags		= FBINFO_HWACCEL_YPAN;

	fb_info.pseudo_palette	= current_par.pseudo_palette;



	strcpy(fb_info.fix.id, "Acorn");

drivers/video/fbdev/g364fb.c

+1 −1
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ int __init g364fb_init(void) 
	fb_info.screen_base = (char *) G364_MEM_BASE;	/* virtual kernel address */

	fb_info.var = fb_var;

	fb_info.fix = fb_fix;

	fb_info.flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

	fb_info.flags = FBINFO_HWACCEL_YPAN;



	fb_alloc_cmap(&fb_info.cmap, 255, 0);

drivers/video/fbdev/hpfb.c

+0 −1
Original line number Diff line number Diff line
@@ -287,7 +287,6 @@ static int hpfb_init_one(unsigned long phys_base, unsigned long virt_base) 
	else

		strcat(fb_info.fix.id, "Catseye");

	fb_info.fbops = &hpfb_ops;

	fb_info.flags = FBINFO_DEFAULT;

	fb_info.var   = hpfb_defined;

	fb_info.screen_base = (char *)fb_start;

drivers/video/fbdev/macfb.c

+0 −1
Original line number Diff line number Diff line
@@ -876,7 +876,6 @@ static int __init macfb_init(void) 
	fb_info.var		= macfb_defined;

	fb_info.fix		= macfb_fix;

	fb_info.pseudo_palette	= pseudo_palette;

	fb_info.flags		= FBINFO_DEFAULT;



	err = fb_alloc_cmap(&fb_info.cmap, video_cmap_len, 0);

	if (err)