Commit 6403298c authored by Jeffrey Hugo's avatar Jeffrey Hugo Committed by Manivannan Sadhasivam
Browse files

bus: mhi: core: Fix check for syserr at power_up 



The check to see if we have reset the device after detecting syserr at
power_up is inverted.  wait_for_event_timeout() returns 0 on failure,
and a positive value on success.  The check is looking for non-zero
as a failure, which is likely to incorrectly cause a device init failure
if syserr was detected at power_up.  Fix this.

Fixes: e18d4e9f ("bus: mhi: core: Handle syserr during power_up")
Signed-off-by: default avatarJeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/1613165243-23359-1-git-send-email-jhugo@codeaurora.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent aaca4233

drivers/bus/mhi/core/pm.c

+1 −1
Original line number Diff line number Diff line
@@ -1101,7 +1101,7 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl) 
							   &val) ||

					!val,

				msecs_to_jiffies(mhi_cntrl->timeout_ms));

		if (ret) {

		if (!ret) {

			ret = -EIO;

			dev_info(dev, "Failed to reset MHI due to syserr state\n");

			goto error_bhi_offset;