Skip to content
Commit 643a16a0 authored by Zheng Wang's avatar Zheng Wang Committed by Greg Kroah-Hartman
Browse files

misc: sgi-gru: fix use-after-free error in gru_set_context_option, gru_fault...


misc: sgi-gru: fix use-after-free error in gru_set_context_option, gru_fault and gru_handle_user_call_os

In some bad situation, the gts may be freed gru_check_chiplet_assignment.
The call chain can be gru_unload_context->gru_free_gru_context->gts_drop
and kfree finally. However, the caller didn't know if the gts is freed
or not and use it afterwards. This will trigger a Use after Free bug.

Fix it by introducing a return value to see if it's in error path or not.
Free the gts in caller if gru_check_chiplet_assignment check failed.

Fixes: 55484c45 ("gru: allow users to specify gru chiplet 2")
Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
Acked-by: default avatarDimitri Sivanich <sivanich@hpe.com>
Link: https://lore.kernel.org/r/20221110035033.19498-1-zyytlz.wz@163.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd2c930c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment