Commit 648ce7fd authored Jul 04, 2021 by Jagan Teki Committed by Philippe Cornu Jul 19, 2021

drm/stm: ltdc: Silence -EPROBE_DEFER till bridge attached



As dw-mipi-dsi supported all possible ways to find the DSI
devices. It can take multiple iterations for ltdc to find
all components attached to the DSI bridge.

The current ltdc driver failed to find the endpoint as
it returned -EINVAL for the first iteration itself. This leads
to following error:

[    3.099289] [drm:ltdc_load] *ERROR* init encoder endpoint 0

So, check the return value and cleanup the encoder only if it's
not -EPROBE_DEFER. This make all components in the attached DSI
bridge found properly.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Tested-by: Yannick Fertre <yannick.fertre@foss.st.com>
Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
Signed-off-by: Philippe Cornu <philippe.cornu@foss.st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210704135914.268308-1-jagan@amarulasolutions.com

parent 57f6190a

drivers/gpu/drm/stm/ltdc.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -1121,8 +1121,9 @@ static int ltdc_encoder_init(struct drm_device ddev, struct drm_bridge bridge)

		ret = drm_bridge_attach(encoder, bridge, NULL, 0);
		if (ret) {
		if (ret != -EPROBE_DEFER)
		drm_encoder_cleanup(encoder);
		return -EINVAL;
		return ret;
		}

		DRM_DEBUG_DRIVER("Bridge encoder:%d created\n", encoder->base.id);
		@@ -1265,6 +1266,7 @@ int ltdc_load(struct drm_device *ddev)
		if (bridge) {
		ret = ltdc_encoder_init(ddev, bridge);
		if (ret) {
		if (ret != -EPROBE_DEFER)
		DRM_ERROR("init encoder endpoint %d\n", i);
		goto err;
		}