Commit 64ea6e44 authored by Phil Auld's avatar Phil Auld Committed by Thomas Gleixner
Browse files

cpu/hotplug: Make target_store() a nop when target == state 



Writing the current state back in hotplug/target calls cpu_down()
which will set cpu dying even when it isn't and then nothing will
ever clear it. A stress test that reads values and writes them back
for all cpu device files in sysfs will trigger the BUG() in
select_fallback_rq once all cpus are marked as dying.

kernel/cpu.c::target_store()
	...
        if (st->state < target)
                ret = cpu_up(dev->id, target);
        else
                ret = cpu_down(dev->id, target);

cpu_down() -> cpu_set_state()
	 bool bringup = st->state < target;
	 ...
	 if (cpu_dying(cpu) != !bringup)
		set_cpu_dying(cpu, !bringup);

Fix this by letting state==target fall through in the target_store()
conditional. Also make sure st->target == target in that case.

Fixes: 757c989b ("cpu/hotplug: Make target state writeable")
Signed-off-by: default avatarPhil Auld <pauld@redhat.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20221117162329.3164999-2-pauld@redhat.com
parent b7b275e6

kernel/cpu.c

+3 −1
Original line number Diff line number Diff line
@@ -2326,8 +2326,10 @@ static ssize_t target_store(struct device *dev, struct device_attribute *attr, 


	if (st->state < target)

		ret = cpu_up(dev->id, target);

	else

	else if (st->state > target)

		ret = cpu_down(dev->id, target);

	else if (WARN_ON(st->target != target))

		st->target = target;

out:

	unlock_device_hotplug();

	return ret ? ret : count;