Unverified Commit 65edda60 authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Do not print IPC error message twice 



ENABLE_LOGS and SYSTEM_TIME IPCs call LARGE_CONFIG_SET internally which
dumps an error message in case of an error. There is no need to repeat
the process in the top level handler.

Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221010121955.718168-13-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2d27a1ca

sound/soc/intel/avs/messages.c

+4 −15
Original line number Diff line number Diff line
@@ -687,20 +687,13 @@ int avs_ipc_get_modules_info(struct avs_dev *adev, struct avs_mods_info **info) 


int avs_ipc_set_enable_logs(struct avs_dev *adev, u8 *log_info, size_t size)

{

	int ret;



	ret = avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID,

	return avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID,

					AVS_BASEFW_ENABLE_LOGS, log_info, size);

	if (ret)

		dev_err(adev->dev, "enable logs failed: %d\n", ret);



	return ret;

}



int avs_ipc_set_system_time(struct avs_dev *adev)

{

	struct avs_sys_time sys_time;

	int ret;

	u64 us;



	/* firmware expects UTC time in micro seconds */
@@ -708,12 +701,8 @@ int avs_ipc_set_system_time(struct avs_dev *adev) 
	sys_time.val_l = us & UINT_MAX;

	sys_time.val_u = us >> 32;



	ret = avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID,

	return avs_ipc_set_large_config(adev, AVS_BASEFW_MOD_ID, AVS_BASEFW_INST_ID,

					AVS_BASEFW_SYSTEM_TIME, (u8 *)&sys_time, sizeof(sys_time));

	if (ret)

		dev_err(adev->dev, "set system time failed: %d\n", ret);



	return ret;

}



int avs_ipc_copier_set_sink_format(struct avs_dev *adev, u16 module_id,