Commit 660ba678 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handle 



kobject_init_and_add() takes reference even when it fails.
According to the doc of kobject_init_and_add()

   If this function returns an error, kobject_put() must be called to
   properly clean up the memory associated with the object.

Fix this issue by calling kobject_put().

Fixes: 948af1f0 ("firmware: Basic dmi-sysfs support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220511071421.9769-1-linmq006@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 077f5d90

drivers/firmware/dmi-sysfs.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -604,7 +604,7 @@ static void __init dmi_sysfs_register_handle(const struct dmi_header *dh, 
				    "%d-%d", dh->type, entry->instance);

				    "%d-%d", dh->type, entry->instance);





	if (*ret) {

	if (*ret) {

		kfree(entry);

		kobject_put(&entry->kobj);

		return;

		return;

	}

	}