Commit 66813970 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/goldfishfb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-17-tzimmermann@suse.de
parent a41410a0

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -1800,9 +1800,7 @@ config FB_GOLDFISH 
	tristate "Goldfish Framebuffer"

	depends on FB

	depends on GOLDFISH || COMPILE_TEST

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	help

	  Framebuffer driver for Goldfish Virtual Platform

drivers/video/fbdev/goldfishfb.c

+1 −3
Original line number Diff line number Diff line
@@ -162,14 +162,12 @@ static int goldfish_fb_blank(int blank, struct fb_info *info) 


static const struct fb_ops goldfish_fb_ops = {

	.owner          = THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var   = goldfish_fb_check_var,

	.fb_set_par     = goldfish_fb_set_par,

	.fb_setcolreg   = goldfish_fb_setcolreg,

	.fb_pan_display = goldfish_fb_pan_display,

	.fb_blank	= goldfish_fb_blank,

	.fb_fillrect    = cfb_fillrect,

	.fb_copyarea    = cfb_copyarea,

	.fb_imageblit   = cfb_imageblit,

};