Commit 668dc8af authored by Yuan Can's avatar Yuan Can Committed by Vinod Koul
Browse files

phy: qcom-snps: Use dev_err_probe() to simplify code 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20220922111228.36355-8-yuancan@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 72f1f608

drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c

+6 −12
Original line number Diff line number Diff line
@@ -559,12 +559,9 @@ static int qcom_snps_hsphy_probe(struct platform_device *pdev) 
		return PTR_ERR(hsphy->base);



	hsphy->ref_clk = devm_clk_get(dev, "ref");

	if (IS_ERR(hsphy->ref_clk)) {

		ret = PTR_ERR(hsphy->ref_clk);

		if (ret != -EPROBE_DEFER)

			dev_err(dev, "failed to get ref clk, %d\n", ret);

		return ret;

	}

	if (IS_ERR(hsphy->ref_clk))

		return dev_err_probe(dev, PTR_ERR(hsphy->ref_clk),

				     "failed to get ref clk\n");



	hsphy->phy_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);

	if (IS_ERR(hsphy->phy_reset)) {
@@ -577,12 +574,9 @@ static int qcom_snps_hsphy_probe(struct platform_device *pdev) 
		hsphy->vregs[i].supply = qcom_snps_hsphy_vreg_names[i];



	ret = devm_regulator_bulk_get(dev, num, hsphy->vregs);

	if (ret) {

		if (ret != -EPROBE_DEFER)

			dev_err(dev, "failed to get regulator supplies: %d\n",

				ret);

		return ret;

	}

	if (ret)

		return dev_err_probe(dev, ret,

				     "failed to get regulator supplies\n");



	pm_runtime_set_active(dev);

	pm_runtime_enable(dev);