Commit 688baac1 authored by Dan Williams's avatar Dan Williams
Browse files

cxl/regs: Clarify when a 'struct cxl_register_map' is input vs output 



The @map parameter to cxl_probe_X_registers() is filled in with the
mapping parameters of the register block. The @map parameter to
cxl_map_X_registers() only reads that information to perform the
mapping. Mark @map const for cxl_map_X_registers() to clarify that it is
only an input to those helpers.

Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/168679258103.3436160.4941603739448763855.stgit@dwillia2-xfh.jf.intel.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 9561de3a

drivers/cxl/core/regs.c

+4 −4
Original line number Diff line number Diff line
@@ -200,10 +200,10 @@ void __iomem *devm_cxl_iomap_block(struct device *dev, resource_size_t addr, 
}



int cxl_map_component_regs(struct device *dev, struct cxl_component_regs *regs,

			   struct cxl_register_map *map, unsigned long map_mask)

			   const struct cxl_register_map *map, unsigned long map_mask)

{

	struct mapinfo {

		struct cxl_reg_map *rmap;

		const struct cxl_reg_map *rmap;

		void __iomem **addr;

	} mapinfo[] = {

		{ &map->component_map.hdm_decoder, &regs->hdm_decoder },
@@ -233,11 +233,11 @@ EXPORT_SYMBOL_NS_GPL(cxl_map_component_regs, CXL); 


int cxl_map_device_regs(struct device *dev,

			struct cxl_device_regs *regs,

			struct cxl_register_map *map)

			const struct cxl_register_map *map)

{

	resource_size_t phys_addr = map->resource;

	struct mapinfo {

		struct cxl_reg_map *rmap;

		const struct cxl_reg_map *rmap;

		void __iomem **addr;

	} mapinfo[] = {

		{ &map->device_map.status, &regs->status, },

drivers/cxl/cxl.h

+2 −2
Original line number Diff line number Diff line
@@ -254,10 +254,10 @@ void cxl_probe_component_regs(struct device *dev, void __iomem *base, 
void cxl_probe_device_regs(struct device *dev, void __iomem *base,

			   struct cxl_device_reg_map *map);

int cxl_map_component_regs(struct device *dev, struct cxl_component_regs *regs,

			   struct cxl_register_map *map,

			   const struct cxl_register_map *map,

			   unsigned long map_mask);

int cxl_map_device_regs(struct device *dev, struct cxl_device_regs *regs,

			struct cxl_register_map *map);

			const struct cxl_register_map *map);



enum cxl_regloc_type;

int cxl_find_regblock(struct pci_dev *pdev, enum cxl_regloc_type type,