Commit 68ff3cba authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf intel-pt: decoder: Factor out clearing of FUP (Flow Update) event variables 



Factor out clearing of FUP (Flow Update) event variables, to avoid code duplication.

Committer Notes:

From the Intel documentation:

<quote>
Flow Update Packets (FUP): FUPs provide the source IP addresses for
asynchronous events (interrupt and exceptions), as well as other cases
where the source address cannot be determined from the binary.
</quote>

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20220124084201.2699795-7-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cd9111e6

tools/perf/util/intel-pt-decoder/intel-pt-decoder.c

+12 −12
Original line number Diff line number Diff line
@@ -1206,6 +1206,16 @@ static int intel_pt_walk_insn(struct intel_pt_decoder *decoder, 
	return err;

}



static void intel_pt_clear_fup_event(struct intel_pt_decoder *decoder)

{

	decoder->set_fup_tx_flags = false;

	decoder->set_fup_ptw = false;

	decoder->set_fup_mwait = false;

	decoder->set_fup_pwre = false;

	decoder->set_fup_exstop = false;

	decoder->set_fup_bep = false;

}



static bool intel_pt_fup_event(struct intel_pt_decoder *decoder)

{

	enum intel_pt_sample_type type = decoder->state.type;
@@ -1623,12 +1633,7 @@ static int intel_pt_overflow(struct intel_pt_decoder *decoder) 
	decoder->state.from_ip = decoder->ip;

	decoder->ip = 0;

	decoder->pge = false;

	decoder->set_fup_tx_flags = false;

	decoder->set_fup_ptw = false;

	decoder->set_fup_mwait = false;

	decoder->set_fup_pwre = false;

	decoder->set_fup_exstop = false;

	decoder->set_fup_bep = false;

	intel_pt_clear_fup_event(decoder);

	decoder->overflow = true;

	return -EOVERFLOW;

}
@@ -3518,12 +3523,7 @@ static int intel_pt_sync_ip(struct intel_pt_decoder *decoder) 
{

	int err;



	decoder->set_fup_tx_flags = false;

	decoder->set_fup_ptw = false;

	decoder->set_fup_mwait = false;

	decoder->set_fup_pwre = false;

	decoder->set_fup_exstop = false;

	decoder->set_fup_bep = false;

	intel_pt_clear_fup_event(decoder);

	decoder->overflow = false;



	if (!decoder->branch_enable) {