Unverified Commit 69cf63b6 authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: simple-card-utils: fixup simple_util_startup() error handling 



It should use "goto" instead of "return"

Fixes: 5ca2ab45 ("ASoC: simple-card-utils: Add new system-clock-fixed flag")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/202309141205.ITZeDJxV-lkp@intel.com/
Closes: https://lore.kernel.org/all/202309151840.au9Aa2W4-lkp@intel.com/


Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87v8c76jnz.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fb0b8d29

sound/soc/generic/simple-card-utils.c

+2 −1
Original line number Diff line number Diff line
@@ -310,7 +310,8 @@ int asoc_simple_startup(struct snd_pcm_substream *substream) 
		if (fixed_sysclk % props->mclk_fs) {

			dev_err(rtd->dev, "fixed sysclk %u not divisible by mclk_fs %u\n",

				fixed_sysclk, props->mclk_fs);

			return -EINVAL;

			ret = -EINVAL;

			goto codec_err;

		}

		ret = snd_pcm_hw_constraint_minmax(substream->runtime, SNDRV_PCM_HW_PARAM_RATE,

			fixed_rate, fixed_rate);