Unverified Commit 6a534cfc authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Mark Brown
Browse files

ASoC: soc-core.c: remove useless dev_dbg() 



soc-core.c is using dev_dbg(), but some of them are useless.
It indicates many dev_dbg() at snd_soc_runtime_get_dai_fmt(),
but all of them are just noise, almost no meanings.

dev_dbg() on soc_probe_link_dais() indicates dai link and its
loop order, but it is just noise, no information.

dev_dbg() on snd_soc_register_dai() is duplicated.

This patch cleanup these.

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ttyy64cy.wl-kuninori.morimoto.gx@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4740479e

sound/soc/soc-core.c

+0 −13
Original line number Diff line number Diff line
@@ -1033,7 +1033,6 @@ static void snd_soc_runtime_get_dai_fmt(struct snd_soc_pcm_runtime *rtd) 
{

	struct snd_soc_dai_link *dai_link = rtd->dai_link;

	struct snd_soc_dai *dai, *not_used;

	struct device *dev = rtd->dev;

	u64 pos, possible_fmt;

	unsigned int mask = 0, dai_fmt = 0;

	int i, j, priority, pri, until;
@@ -1075,8 +1074,6 @@ static void snd_soc_runtime_get_dai_fmt(struct snd_soc_pcm_runtime *rtd) 
	 */

	until = snd_soc_dai_get_fmt_max_priority(rtd);

	for (priority = 1; priority <= until; priority++) {



		dev_dbg(dev, "priority = %d\n", priority);

		for_each_rtd_dais(rtd, j, not_used) {



			possible_fmt = ULLONG_MAX;
@@ -1085,7 +1082,6 @@ static void snd_soc_runtime_get_dai_fmt(struct snd_soc_pcm_runtime *rtd) 


				pri = (j >= i) ? priority : priority - 1;

				fmt = snd_soc_dai_get_fmt(dai, pri);

				dev_dbg(dev, "%s: (pri, fmt) = (%d, %016llX)\n", dai->name, pri, fmt);

				possible_fmt &= fmt;

			}

			if (possible_fmt)
@@ -1095,8 +1091,6 @@ static void snd_soc_runtime_get_dai_fmt(struct snd_soc_pcm_runtime *rtd) 
	/* Not Found */

	return;

found:

	dev_dbg(dev, "found auto selected format: %016llX\n", possible_fmt);



	/*

	 * convert POSSIBLE_DAIFMT to DAIFMT

	 *
@@ -1457,11 +1451,6 @@ static int soc_probe_link_dais(struct snd_soc_card *card) 


	for_each_comp_order(order) {

		for_each_card_rtds(card, rtd) {



			dev_dbg(card->dev,

				"ASoC: probe %s dai link %d late %d\n",

				card->name, rtd->num, order);



			/* probe all rtd connected DAIs in good order */

			ret = snd_soc_pcm_dai_probe(rtd, order);

			if (ret)
@@ -2421,8 +2410,6 @@ struct snd_soc_dai *snd_soc_register_dai(struct snd_soc_component *component, 
	struct device *dev = component->dev;

	struct snd_soc_dai *dai;



	dev_dbg(dev, "ASoC: dynamically register DAI %s\n", dev_name(dev));



	lockdep_assert_held(&client_mutex);



	dai = devm_kzalloc(dev, sizeof(*dai), GFP_KERNEL);