Commit 6a8fcf7d authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: ibmphp: Remove unused assignments 



Remove variables and assignments that are never used.

Found by Krzysztof using cppcheck, e.g.:

  $ cppcheck --enable=all --force
  unreadVariable drivers/pci/hotplug/ibmphp_res.c:1958 Variable 'bus_sec' is assigned a value that is never used.

Reported-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Link: https://lore.kernel.org/r/20220313192933.434746-6-helgaas@kernel.org


Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent af8b8b6c

drivers/pci/hotplug/ibmphp_hpc.c

+0 −2
Original line number Diff line number Diff line
@@ -325,11 +325,9 @@ static u8 i2c_ctrl_write(struct controller *ctlr_ptr, void __iomem *WPGBbar, u8 
static u8 isa_ctrl_read(struct controller *ctlr_ptr, u8 offset)

{

	u16 start_address;

	u16 end_address;

	u8 data;



	start_address = ctlr_ptr->u.isa_ctlr.io_start;

	end_address = ctlr_ptr->u.isa_ctlr.io_end;

	data = inb(start_address + offset);

	return data;

}

drivers/pci/hotplug/ibmphp_res.c

+1 −2
Original line number Diff line number Diff line
@@ -1955,7 +1955,7 @@ static int __init update_bridge_ranges(struct bus_node **bus) 
						bus_sec = find_bus_wprev(sec_busno, NULL, 0);

						/* this bus structure doesn't exist yet, PPB was configured during previous loading of ibmphp */

						if (!bus_sec) {

							bus_sec = alloc_error_bus(NULL, sec_busno, 1);

							alloc_error_bus(NULL, sec_busno, 1);

							/* the rest will be populated during NVRAM call */

							return 0;

						}
@@ -2114,6 +2114,5 @@ static int __init update_bridge_ranges(struct bus_node **bus) 
		}	/* end for function */

	}	/* end for device */



	bus = &bus_cur;

	return 0;

}