Commit 6ab7ca51 authored by Lee Jones's avatar Lee Jones Committed by Martin K. Petersen
Browse files

scsi: isci: phy: Provide function name and demote non-conforming header 

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/isci/phy.c:354: warning: Function parameter or member 'iphy' not described in 'phy_get_non_dummy_port'
 drivers/scsi/isci/phy.c:354: warning: expecting prototype for If the phy is(). Prototype was for phy_get_non_dummy_port() instead
 drivers/scsi/isci/phy.c:371: warning: Function parameter or member 'iphy' not described in 'sci_phy_set_port'
 drivers/scsi/isci/phy.c:371: warning: Function parameter or member 'iport' not described in 'sci_phy_set_port'

Link: https://lore.kernel.org/r/20210317091230.2912389-20-lee.jones@linaro.org


Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6af1d9bd

drivers/scsi/isci/phy.c

+6 −7
Original line number Diff line number Diff line
@@ -339,10 +339,11 @@ static void phy_sata_timeout(struct timer_list *t) 
}



/**

 * This method returns the port currently containing this phy. If the phy is

 *    currently contained by the dummy port, then the phy is considered to not

 *    be part of a port.

 * @sci_phy: This parameter specifies the phy for which to retrieve the

 * phy_get_non_dummy_port() - This method returns the port currently containing

 * this phy. If the phy is currently contained by the dummy port, then the phy

 * is considered to not be part of a port.

 *

 * @iphy: This parameter specifies the phy for which to retrieve the

 *    containing port.

 *

 * This method returns a handle to a port that contains the supplied phy.
@@ -360,10 +361,8 @@ struct isci_port *phy_get_non_dummy_port(struct isci_phy *iphy) 
	return iphy->owning_port;

}



/**

/*

 * sci_phy_set_port() - This method will assign a port to the phy object.

 * @out]: iphy This parameter specifies the phy for which to assign a port

 *    object.

 */

void sci_phy_set_port(

	struct isci_phy *iphy,