Commit 6ca3549d authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Mauro Carvalho Chehab
Browse files

media: platform: s5p-mfc: Fix adding a standard frame skip mode control 



Add proper control type to the recently introduced
V4L2_CID_MPEG_VIDEO_FRAME_SKIP_MODE control. This will forward it to
v4l2_ctrl_new_std_menu() not v4l2_ctrl_new_std(), what causes the
failure. This fixes the following warning during driver initialization:

s5p_mfc_enc_ctrls_setup:2671: Adding control (18) failed
s5p_mfc_open:811: Failed to setup mfc controls

Fixes: ef56b3ee ("media: s5p-mfc: Use standard frame skip mode control")
Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent bfea1d81

drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

+1 −0
Original line number Diff line number Diff line
@@ -263,6 +263,7 @@ static struct mfc_control controls[] = { 
	},

	{

		.id = V4L2_CID_MPEG_VIDEO_FRAME_SKIP_MODE,

		.type = V4L2_CTRL_TYPE_MENU,

		.maximum = V4L2_MPEG_VIDEO_FRAME_SKIP_MODE_BUF_LIMIT,

		.default_value = V4L2_MPEG_VIDEO_FRAME_SKIP_MODE_DISABLED,

	},