Unverified Commit 6d5e37b0 authored Jun 16, 2022 by Pierre-Louis Bossart Committed by Mark Brown Jun 17, 2022

ASoC: SOF: Intel: hda-dsp: report error on power-up/down

dev_dbg() is not good-enough since the flow returns an error.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220616215351.135643-2-pierre-louis.bossart@linux.intel.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 2964e31c

sound/soc/sof/intel/hda-dsp.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -743,7 +743,7 @@ int hda_dsp_resume(struct snd_sof_dev *sdev)
		if (hlink->ref_count) {
		ret = snd_hdac_ext_bus_link_power_up(hlink);
		if (ret < 0) {
		dev_dbg(sdev->dev,
		dev_err(sdev->dev,
		"error %d in %s: failed to power up links",
		ret, __func__);
		return ret;
		@@ -871,7 +871,7 @@ int hda_dsp_suspend(struct snd_sof_dev *sdev, u32 target_state)
		/* no link can be powered in s0ix state */
		ret = snd_hdac_ext_bus_link_power_down_all(bus);
		if (ret < 0) {
		dev_dbg(sdev->dev,
		dev_err(sdev->dev,
		"error %d in %s: failed to power down links",
		ret, __func__);
		return ret;